fix(litellm): fix gen_ai.request.messages to be as expected
#5255
+316
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
…inal messages and handle data URLs correctly
Base automatically changed from
constantinius/fix/redact-message-parts-type-blob
to
master
January 13, 2026 09:56
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Litellm
Other
Documentation 📚
Internal Changes 🔧Release
Other
🤖 This preview updates automatically when you update the PR. |
| if item.get("type") == "image_url": | ||
| image_url = item.get("image_url") or {} | ||
| url = image_url.get("url", "") | ||
| if url.startswith("data:") and ";base64," in url: |
There was a problem hiding this comment.
Case-sensitive base64 check bypasses blob detection and redaction
Low Severity
The check ";base64," in url is case-sensitive, but per RFC 2397 the base64 token in data URIs is case-insensitive. Data URIs with uppercase variants like data:image/png;BASE64,... would not be recognized as base64 data URIs, causing them to be converted to type: "uri" instead of type: "blob". Since redact_blob_message_parts only redacts blob types, these inline base64 data URIs would not be redacted, potentially exposing sensitive image data in telemetry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Closes https://linear.app/getsentry/issue/TET-1635/redact-images-litellm